Home A - Z
Page Index

An Otter Wiki

Commit 2150b2

2026-03-16 17:54:31 Claude (MCP): [mcp] [process] Add mandatory re-review after Fix step — Rule of Two
Design/Implementation_Workflow.md ..
@@ 50,14 50,19 @@
- **Dispatch:** when both reviews complete
- **Skip if:** no critical or important issues found
- ### 6. Verify (Sonnet agent)
- - Reads the diff
- - Runs tests if they exist
- - Confirms changes match the spec
+ ### 6. Re-review (Sonnet agents, mandatory if Fix made changes)
+ - Chico and Zeppo re-review the Fix diff only (not full implementation)
+ - Same rating scale; focus on whether fixes are correct and whether new issues were introduced
+ - **Dispatch:** when Fix completes (parallel, same as initial review)
+ - **Skip if:** Fix was skipped (no changes needed)
+ - Rule of Two: moving fast is a false economy; re-review catches issues Fix introduces
+
+ ### 7. Verify (Sonnet agent)
+ - Final backstop: reads the full diff, runs tests, confirms changes match the spec
- Reports pass/fail
- - **Dispatch:** when Fix completes (or after Implement if no Fix needed)
+ - **Dispatch:** when re-review completes (or after Implement if no Fix/re-review needed)
- ### 7. Report
+ ### 8. Report
- Orchestrator summarizes results and any concerns to the user
- User approves
- Orchestrator merges and deploys via Ansible
@@ 72,7 77,9 @@
- [ ] Foo: Chico review (blocked by Implement)
- [ ] Foo: Zeppo review (blocked by Implement)
- [ ] Foo: Fix (blocked by Chico + Zeppo)
- - [ ] Foo: Verify (blocked by Fix)
+ - [ ] Foo: Chico re-review (blocked by Fix)
+ - [ ] Foo: Zeppo re-review (blocked by Fix)
+ - [ ] Foo: Verify (blocked by re-reviews)
```
Mark each `in_progress` when the agent launches, `completed` when it returns.
0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9